Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check result for undefined and prevent JSON Parse #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bpeters
Copy link

@bpeters bpeters commented Jul 24, 2016

I was running into issues where getState script would result in undefined which would cause the JSON.parse(result) to throw and error.

@andrehaveman
Copy link
Owner

I don't see the use of this change. The JSON.parse error is already handled by try/catch block. This change leads to the undesired result that the callback is called without an error and also without a result.

@Alutun
Copy link

Alutun commented Oct 16, 2016

@bpeters Di you find the cause of it ? i'm running into the same issue and cannot find the root cause of this.

@will234
Copy link

will234 commented Jul 30, 2017

nn

@nzec
Copy link

nzec commented Jan 17, 2018

@bpeters I don't think this fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants