Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEVC codec support for HTSP (TV) streams #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scotty007
Copy link

Pretty simple else if addition.
HEVC is used by e.g. German HD TV via DVB-T2.

@029A-h
Copy link

029A-h commented Aug 31, 2020

DVB-T2 support would be awesome. Movian is the best client for tvheadend for me but I was unsuccessful in compilation with yout patch.
After adding

      } else if(!strcmp(type, "HEVC")) {
	codec_id = AV_CODEC_ID_HEVC;
	media_type = MEDIA_TYPE_VIDEO;
	nicename = "HEVC";

I got this make error

/home/william/builds/movian/ext/rtmpdump/librtmp/hashswf.c:252:12: error: field ‘ctx’ has incomplete type
   HMAC_CTX ctx;
            ^~~
/home/william/builds/movian/ext/rtmpdump/librtmp/hashswf.c: In function ‘RTMP_HashSWF’:
/home/william/builds/movian/ext/rtmpdump/librtmp/hashswf.c:62:35: warning: implicit declaration of function ‘HMAC_CTX_init’; did you mean ‘HMAC_CTX_new’? [-Wimplicit-function-declaration]
 #define HMAC_setup(ctx, key, len) HMAC_CTX_init(&ctx); HMAC_Init_ex(&ctx, (unsigned char *)key, len, EVP_sha256(), 0)
                                   ^~~~~~~~~~~~~
/home/william/builds/movian/ext/rtmpdump/librtmp/hashswf.c:545:3: note: in expansion of macro ‘HMAC_setup’
   HMAC_setup(in.ctx, "Genuine Adobe Flash Player 001", 30);
   ^~~~~~~~~~
/home/william/builds/movian/ext/rtmpdump/librtmp/hashswf.c:65:25: warning: implicit declaration of function ‘HMAC_CTX_cleanup’; did you mean ‘HMAC_CTX_get_md’? [-Wimplicit-function-declaration]
 #define HMAC_close(ctx) HMAC_CTX_cleanup(&ctx)
                         ^~~~~~~~~~~~~~~~
/home/william/builds/movian/ext/rtmpdump/librtmp/hashswf.c:611:3: note: in expansion of macro ‘HMAC_close’
   HMAC_close(in.ctx);
   ^~~~~~~~~~
make: *** [Makefile:861: /home/william/builds/movian/build.linux/ext/rtmpdump/librtmp/hashswf.o] Error 1
make: *** Waiting for unfinished jobs....
duk_bi_date.c: In function ‘duk__format_parts_iso8601’:
duk_bi_date.c:982:39: warning: ‘%02d’ directive output may be truncated writing 2 bytes into a region of size between 0 and 4 [-Wformat-truncation=]
duk_bi_date.c:982:39: note: directive argument in the range [0, 59]
In file included from /home/william/builds/movian/ext/duktape/duktape.h:130,
                 from duk_internal.h:26:
/home/william/builds/movian/ext/duktape/duk_config.h:1983:26: note: ‘snprintf’ output between 7 and 11 bytes into a destination of size 8
 #define DUK_SNPRINTF     snprintf
duk_bi_date.c:982:4: note: in expansion of macro ‘DUK_SNPRINTF’
duk_bi_date.c:979:39: warning: ‘%02d’ directive output may be truncated writing 2 bytes into a region of size between 0 and 4 [-Wformat-truncation=]
duk_bi_date.c:979:39: note: directive argument in the range [0, 59]
In file included from /home/william/builds/movian/ext/duktape/duktape.h:130,
                 from duk_internal.h:26:
/home/william/builds/movian/ext/duktape/duk_config.h:1983:26: note: ‘snprintf’ output between 7 and 11 bytes into a destination of size 8
 #define DUK_SNPRINTF     snprintf
duk_bi_date.c:979:4: note: in expansion of macro ‘DUK_SNPRINTF’

How can I interpret the failure?
[compiled on Debian Buster]

@scotty007
Copy link
Author

@willi-smith: I don't think the failed build is caused by this patch. It happens while building an external library (librtmp) and it fails for the current master as well. I excluded librtmp via ./configure --disable-librtmp.

@nkichukov
Copy link

Thanks a lot, it works here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants