This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Fix navigation bar icons legibility for API 26 and below #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #507
It seems that devices running Android 8.0 (API 26) and below draw the navigation bar buttons using white or almost white color. At least, as mentioned in the linked issue, vanilla Android, Lineage OS, and EMUI do that.
To my understanding, the Android navigation bar wasn't supposed to have a light color until Android 8.1 (API 27) where a theme attribute
android:lightNavigationBar
was introduced, which allows to explicitly tell the system that we want the buttons to be drawn using a dark color.So I propose:
All of the changes only affect the light theme.
Here is how the navigation bar would look before and after the changes on devices with API 26 and below: