This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
(FIX #814) allow password reveal only before start typing #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small commit should fix issue #814 by disabling the password reveal button if some input on the password input has already been made without the 'reveal password' toggle active.
If the password toggle was set to be enabled before starting to enter the password, it stays enabled and the password can be read.
When disabling the toggle with a password already entered, the toggle button disappears.
It only returns when the password field is empty again.
This should be an easy-to-understand solution for the end user while still providing the security benefit mentioned in #814.