Add super tiny icons as thumbnail provider

[RichyHBM]

Fixes #370 by adding SuperTinyIcons to the repo and adding an automated way of updating icons

[flocke]

This looks really nice and seems like an elegant way of solving this. I will look at it in more detail as soon as I find the time. 👍

[flocke]

Maybe we should also add credits to SuperTinyIcons to the About screen.

[RichyHBM]

I added it into the licenses section in about :)

[alexanderadam]

Is there anything missing (except a rebase)?

[flocke]

No, I just didn't have the time yet to look at the patch in detail. But it's one of the first things on my list after the stable release of 0.7.0.

[flocke]

While this is still something I really want to include at some point, I need to think about it some more. Can someone check how many of the icons in SuperTinyIcons actually are for services that support 2FA? I don't want to automatically pull a bunch of icons of which 50% are actually for services that can't be used with andOTP. We may need to add some kind of filter to only include the icons for 2FA-enabled services.

[alexanderadam]

I don't want to automatically pull a bunch of icons of which 50% are actually for services that can't be used with andOTP. We may need to add some kind of filter to only include the icons for 2FA-enabled services.

I'm not sure about this. Even the ones that don't have a direct corresponding website (let's say the icon of the programming language Python) are useful if you want to save a token for a corresponding community (for instance a Python forum).
The same is probably true for any other of the listed icons.

Because a Python icon sure would be more speaking than an icon of the forum software that is used, right?

Or do you have concerns with some particular examples?

[alexanderadam]

I also wrote something about the file size footprint in case that's your concern.

[flocke]

Now that 0.8.0 is finally released I want to revisit this. But I still think we should implement some kind of whitelist to only include the icons we actually need. It's not really about the size, I'm just opposed to including a bunch of icons for stuff that doesn't even support 2FA. For one I personally think it's just bad practice to include unnecessary stuff and secondly it would probably confuse people. I get a few mails every now and then asking how to add Battle.net or Steam to andOTP because the person saw the icon in the list. In that case it's actually possible but if we include icons for stuff that doesn't even support 2FA it will only increase those kinds of questions.

[alexanderadam]

I get a few mails every now and then asking how to add Battle.net or Steam to andOTP because the person saw the icon in the list. In that case it's actually possible but if we include icons for stuff that doesn't even support 2FA it will only increase those kinds of questions.

IMHO this is an entirely different problem and has nothing to do with super tiny icons.
See: currently andOTP includes a lot of icons for providers that are only regionally relevant for a very small amount of users (say hosting.de which is pretty irrelevant for non german speaking folks or Tesla — I'm not sure what's the percentage of Tesla drivers in andOTP, TU-Berlin, Australian Government, Best Buy etc.).

Meaning that most of the icons will be irrelevant anyway for most people. This is the situation right now. Absolutely independent from the thumbnail provider.
Super Tiny Icons won't change anything regarding this. The situation will still be same. Regardless whether filters are added or not. Simply because the current situation already has this problem.

Therefore the solution for this issue should be something different, right?

1. Automatic icon suggestions

A common solution for this would be proper icon suggestions. So that an icon would be preselected by its caption.

Scanning a code? Fine: andOTP automatically selects the proper icon for it.

2. Good search aliases

If a preselection wasn't possible or was wrong, a good search is essential. For instance a search for crypto currencies could show the bitcoin icon. It should be easy to find it and the search filter should be obvious.

[flocke]

Meaning that most of the icons will be irrelevant anyway for most people. This is the situation right now. Absolutely independent from the thumbnail provider.

The keyword here is "most". If the icon is currently in andOTP then someone requested it at some point. Thus it is relevant for at least that one person. But icons for services that don't even offer 2FA at all would be relevant for nobody.

An automatic assigment of the icon is actually already done since version 0.7.0 (see PR #389 and here).

Search aliases might be a good idea, but they would have to be added manually again, which would increase the maintenance effort even when we use SuperTinyIcons as thumbnail provider.

Like I said, I'm not against using SuperTinyIcons as source for our thumbnails. I'm just against taking all icons and dumping them into andOTP even the services behind the icons don't even offer 2FA.

[alexanderadam]

The keyword here is "most". If the icon is currently in andOTP then someone requested it at some point. Thus it is relevant for at least that one person.

Which is exactly what I wrote.

But icons for services that don't even offer 2FA at all would be relevant for nobody.

I explained why this is not automatically the case on this PR in may:

Even the ones that don't have a direct corresponding website (let's say the icon of the programming language Python) are useful if you want to save a token for a corresponding community (for instance a Python forum).

An automatic assigment of the icon is actually already done since version 0.7.0 (see PR #389 and here).

Great 👍

Search aliases might be a good idea, but they would have to be added manually again, which would increase the maintenance effort even when we use SuperTinyIcons as thumbnail provider.

Yes, I agree with that. But I don't see any other solutions.