Add PHP extensions binary classifiers #2585
Open
+428
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
php-extensions-bin
branch
3 times, most recently
from
dae61bd
to
70531bb
Compare
Signed-off-by: Laurent Goderre <laurent.goderre@docker.com>
LaurentGoderre
force-pushed
the
php-extensions-bin
branch
from
70531bb
to
09c74c3
Compare
|
Thanks for the updates here @LaurentGoderre! I've got some time this afternoon and can give this a look. |
wagoodman
reviewed
Feb 7, 2024
| } | ||
|
|
||
| //nolint:funlen | ||
| func phpExtensionsClassifiers() []Classifier { |
There was a problem hiding this comment.
I don't quite understand the need for so many classifiers, can you help me understand what this is doing? (this should also probably be captured as a comment in the code)
There was a problem hiding this comment.
These are extensions for which the source exists in the PHP codebase but aren't compiled in the main PHP binary. They are optionally compiled when users need it. ex: https://github.com/nextcloud/docker/blob/master/28/fpm-alpine/Dockerfile#L41-L53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.