Arepo (do not merge) #925
Draft
Arepo (do not merge) #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c, add cleanup_code to interface.py, add set_default_parameters to initialize_code
Add basic arepo test. Co-authored-by: Steven Rieder <rieder@users.noreply.github.com>
…mum used timestep sizes increases during a step, it could happen that for particles on the maximum timestep one gravity half-step is not applied (because HighestActiveTimeBin increases)
Three of four recent commits from arepo on gitlab (https://gitlab.mpcdf.mpg.de/vrs/arepo). Documentation update omitted since arepo documentation has been removed here.
Preparing to run the Arepo example `isolated_galaxy_collusionless_3d`. Arepo flags (in `arepo/src/Makefile`) sourced from `arepo/run/examples/myexample/Config.sh`. Co-authored-by: thomasguillet <thomasguillet@users.noreply.github.com>
May want to remove from child makefile to avoid duplication. Co-authored-by: Steven Rieder <rieder@users.noreply.github.com>
Add Arepo flag "Multiple restarts" (effect not fully tested). Co-authored-by: Steven Rieder <rieder@users.noreply.github.com>
Modify test parameters. Co-authored-by: Steven Rieder <rieder@users.noreply.github.com>
Avoid HDF5 - we will use AMUSE to extract data instead of snapshotting.
The multiple restarts flag keeps more than one restart file for unreliable systems.
Re-add initialization code to test script.
Include naive find_particle_with_ID to be optimized later. Co-authored-by: Thomas Guillet <thomasguillet@users.noreply.github.com>
Currently with a naive search for particle ID.
Using `size_t` for the output position ID, but this is defined in Arepo as an unsigned int.
Based on test_simple.py.
Removed call to missing `write_compile_time_options_in_hdf5` function in `src/io/io.c`. In Arepo this function is written to a file by a perl script at compile time.
Also fill in gravitational acceleration getter.
This breaks the former "collisionless galaxy 3D" example, since the Arepo compiler flags are hard-coded into the Makefiles. Once the ICs file has been copied from the Arepo source (as outlined in ICs.placeholder) the new python script `test_noh3d.py` runs the example and saves figures of the output at t = 0.1, 1.0 and 1.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add Arepo (WIP, do not merge!)