Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate standalone amuse-units package #634

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rieder
Copy link
Member

@rieder rieder commented Jun 2, 2020

No description provided.

@rieder rieder requested a review from ipelupessy June 2, 2020 12:16
@rieder
Copy link
Member Author

rieder commented Jun 2, 2020

installing amuse-units and then amuse-framework seems to work for me, as does installing just amuse-units.

@ipelupessy
Copy link
Member

ok, but I think amuse units component themselves need some work to remove e.g. the amuse exceptions etc

@ipelupessy
Copy link
Member

I think the exceptions can be converted to normal exceptions, however there is also some support utilities used (late, memoization

@rieder
Copy link
Member Author

rieder commented Jun 2, 2020

I'll check. For many of those I don't think I know what they do...

@ipelupessy
Copy link
Member

i think late does what functools cached_property (introduced in 3.8) does and the memoization is lru_cache (3.3 or so)

@rieder
Copy link
Member Author

rieder commented Jun 2, 2020

Ok. I'm not yet happy with a 3.8 dependency but 3.3 is certainly fine.

@ipelupessy
Copy link
Member

memoization speeds up the unit module considerably, the late stuff I have never really seen what it adds though

@rieder
Copy link
Member Author

rieder commented Jun 2, 2020

memoization speeds up the unit module considerably

Ah, I see. I guess it should have been memorize :). I'll see if I can replace that.

@rieder
Copy link
Member Author

rieder commented Jun 2, 2020

lru_cache is not a simple drop-in replacement unfortunately... needs a bit more work.

@rieder
Copy link
Member Author

rieder commented Jun 2, 2020

here's a description of how lru_cache could work for methods... not sure I like this. https://stackoverflow.com/questions/33672412/python-functools-lru-cache-with-class-methods-release-object

@ipelupessy
Copy link
Member

just copying the necessary bits is always an option...

@ipelupessy
Copy link
Member

(ie just putting the late and memoization bits also in units) with a comment and view of replacing them with standard constructs...

@stale
Copy link

stale bot commented Mar 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 4, 2022
@ipelupessy
Copy link
Member

keep open

@stale
Copy link

stale bot commented May 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label May 4, 2022
@rieder rieder removed the stale Issues that have been around for a while without updates label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants