Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work on update secular multiple #557

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

work on update secular multiple #557

wants to merge 6 commits into from

Conversation

ipelupessy
Copy link
Member

not for merging yet

@ipelupessy ipelupessy mentioned this pull request Dec 18, 2019
Open
@stale
Copy link

stale bot commented Mar 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 4, 2022
@ipelupessy
Copy link
Member Author

it is still a good idea; best done by someone who needs the updated version though

@stale
Copy link

stale bot commented May 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues that have been around for a while without updates label May 4, 2022
@ipelupessy
Copy link
Member Author

keep

@stale stale bot removed the stale Issues that have been around for a while without updates label May 5, 2022
@ipelupessy ipelupessy mentioned this pull request Sep 22, 2022
Open
@ipelupessy
Copy link
Member Author

so it needs a bit of work to reconsolidate the interface of amuse with the interface.cpp of secular multiple

@rieder
Copy link
Member

rieder commented Apr 15, 2023

The original developer of Secular Multiple has left the field now, I'm not sure if development continues elsewhere (I think it doesn't for now).
It would be good to test/finish this, since at least we then have the latest version included. It seems to be a lot cleaner than the original version.

@rieder
Copy link
Member

rieder commented Apr 15, 2023

As for the interface conflicts - best to use the version from this PR, we can clean it up again later.

rieder
rieder reviewed May 16, 2023
View reviewed changes
src/amuse/community/secularmultiple/Makefile
make -C . download

download:
git clone -b master https://github.com/hamers/secularmultiple.git src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should download a specific version rather than just the latest (even though it's no longer updated here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rieder rieder rieder left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
keep-open
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ipelupessy @rieder