Skip to content

Commit

Permalink
Updated requirements
Browse files Browse the repository at this point in the history 
Some out of necessity, others because we haven't tested old versions for a while.
  • Loading branch information
@rieder
rieder committed Apr 4, 2023
1 parent c6224cc commit 581d367
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions requirements.txt
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
setuptools>=45
setuptools>=67
setuptools_scm>=6
wheel
docutils>=0.6
numpy>=1.2.2
pytest>=3.0
mpi4py>=1.1.0
h5py>=1.1.0
wheel>=0.37
docutils>=0.18
numpy>=1.20
pytest>=7.0
mpi4py>=3.0
h5py>=3.0

3 comments on commit 581d367

@ipelupessy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change these only if you know for sure that they are necessary...it happens quite often that you have to work with old versions of prereq on supercomputers..also
setuptools 67 is really new (I am on 65 and 67 is just available as update, and that is for opensuse tumbleweed a rolling distribution)

@rieder
Copy link
Member Author

@rieder rieder commented on 581d367 Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I noticed that at least the update to a quite recent setuptools was necessary for the editable install to work.
The requirements in this file aren't "hard" - that would be in the setup.py.
As for the others, we need to have a better testing system in place for the other version checks. Usually, the most recent version of everything is installed and tested, but older versions aren't.

@ipelupessy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, its the "from setuptools.command.build import build" line that can give trouble (was distutils)..it gets rid of a deprecation warning but I guess its then pretty recent change
(if someone complaints, maybe revert to importing from distutils)

Please sign in to comment.