You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevented the overlapping of icons on the home page. - 763cd15
Prevented the footer to go up when there is no content in the page. - fdb8060
Adjusted the signup successful page in registration. - bf7cfa2
Why is the PR commit message/title like this?
Please make sure you name the PR rightfully according to the issue that you wish to solve.
I see various other commits too after the PR was initiated. Are these relevant to the PR that you opened? If then, make sure you merge all together and open up a single commit.
Prevented the footer to go up when there is no content in the page. - fdb80601
I guess this is not the correct way to do this. You just increased the margin-top this may sometimes create a lot of space in between if there is no content. Changing it would be better. @sreyasukavasi3 can you also put some screenshots regarding the signup successful page?
And I am still able to reproduce this issue
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sreyasukavasi3
changed the title
Prevented the overlapping of icons on the home page. - 763cd15
Prevented the footer to go up when there is no content in the page. - fdb8060
Adjusted the signup successful page in registration. - bf7cfa2