Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop DB modify in docker with autosave #214

Closed
wants to merge 1 commit into from

Conversation

rodriciru
Copy link
Contributor

@rodriciru rodriciru commented Oct 24, 2022

Fixes #189
In docker with autosave option ON, db is continuisly growing because of a loop.
Node.js detect crontab.db is modified -> call a method wich creates some cron and other files, and updates the DB -> Db gets modified by this last update -> Node detects Db is modified.........
Result is a huge db size by only one entry.
This PR disable the loop by setting a boolean on certain methods, and enable the call to the method that updtes the db

@rodriciru
Copy link
Contributor Author

Can look at this pr, and tell me your opinion?

@alseambusher
Copy link
Owner

I was thinking of adding your other suggestion https://github.com/louischatriot/nedb#persistence. I am running some tests with it

@rodriciru
Copy link
Contributor Author

That is a workaround, not a solution. DB constantly grows, but after X time it will be reset.
For me, my PR is a fix, so it only grows when it needs to grow, not every time.
And it dosnt have so much risk to use IMO

Copy link

stale bot commented Nov 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 18, 2023
@stale stale bot closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starting docker image with --autosave causes crontab.db to grow continuously
2 participants