Use hyphenation package instead of providing own rules #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hyphenation package already has a large set of different hyphenation rules included for different languages, so it's really a bit redudant if we duplicate the effort for HPDF. Right now this implementation doesn't use the hyphenation package to its full extent, because we still have a hardcoded language list, which in this case is German (which I added) and English. Signed-off-by: aszlig <aszlig@nix.build>
This gets rid of the hardcoded language and instead uses the Hyphenator type from the hyphenation package, which not only brings one variant of a specific language to the table but different variations, like for example english_US and english_GB. Signed-off-by: aszlig <aszlig@nix.build>
|
Fixed in 1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the hyphenation package we not only have access to a bunch of hyphenation rules which we don't need to maintain in HPDF but it also allows to actually easily switch the hyphenator away from the English one, particularly when using Typesetting.
This also gets rid of
Graphics.PDF.Hyphenate, because its functionality is already existing inhyphenation.