Support modern authentication methods for S3. #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Mar 14, 2024
As of alphagov/support#1300, the app is able to use more appropriate authn methods including EC2 instance profile creds and IRSA.
sengi
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Mar 14, 2024
As of alphagov/support#1300, the app is able to use more appropriate authn methods including EC2 instance profile creds and IRSA.
Essentially the same as alphagov/support-api#911. Remove Fog; the standard AWS client library is simpler to use, better documented and easier to secure. This lets us get rid of the nasty long-lived IAM key for authenticating to S3.
|
Simplified the test fixture a bit more. |
robinjam
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially the same as alphagov/support-api#911.
Remove Fog. The standard AWS client library is simpler to use, better documented and easier to secure. This lets us get rid of the nasty long-lived IAM key for authenticating to S3.
Part of alphagov/govuk-helm-charts#1895.