Update pat leave calculations for NI #6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to make the tests slightly easier to read in preparation for adding in context blocks for where the employee lives.
Update the paternity leave calculator for employers to handle employees who live in Northern Ireland—the rules for Northern Ireland-based employees remains the same, they did not change on the 6th April 2024.
Attempt to make the tests slightly easier to read in preparation for adding in context blocks for where the employee lives.
Update the paternity adoption leave calculator for employers to handle employees who live in Northern Ireland—the rules for Northern Ireland-based employees remains the same, they did not change on the 6th April 2024.
Insert a question into the paternity and paternity adoption calculator flows asking where the employee lives. For paternity leave this comes after the first question (where they indicate it is for paternity leave), and for paternity adoption leave it comes after second question (i.e. as soon as we know it's for paternity adoption). Update the comments labelling the questions with numbers (including re-indexing from one, instead of zero, to match the maternity calculator flow).
The calculator now handles employees applying for paternity and paternity adoption leave who live in Northern Ireland. The use of "eg" has been replaced with "for example" to fit GOV.UK style.
Simplify the outcome text when an employee is not entitled to statutory paternity pay.
mtaylorgds
changed the title
mtaylorgds
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the paternity leave calculator to handle employees living in Northern Ireland.
The rules for employees living in Scotland, England, and Wales changed at the start of the new tax year in 2024. However, these changes do NOT apply to employees living in Northern Ireland. Update the calculator to handle Northern Ireland employees by inserting a new question into the flow (in two places—one for the paternity leave flow, and one for paternity adoption leave flow).
There are also a few minor text changes.
Trello ticket
Follow these steps if you are doing a Rails upgrade.