Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Marriage Abroad start page to new flow #6754

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Tetrino
Copy link
Contributor

@Tetrino Tetrino commented Apr 17, 2024

We can't simply unpublish the old start page as this would remove the entire flow as well - something we don't want to do. As a mitigation, the old start page will now redirect to the new flow until the migration is complete.

The heading has been updated to match the new flow.

This must be stripped out ASAP when migration is complete as highest priority.

https://trello.com/c/trq5xjK4/265-get-married-abroad-redirect-the-current-start-page-github-to-the-new-one-via-mainstream

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6754 April 17, 2024 10:12 Inactive
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6754 April 17, 2024 10:21 Inactive
@Tetrino Tetrino marked this pull request as ready for review April 17, 2024 10:26
@Tetrino Tetrino added the DO NOT MERGE Needs further approval before release label Apr 17, 2024
@Tetrino Tetrino requested a review from mtaylorgds April 17, 2024 10:26
Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpicky comment about the formatting of the test.

test/unit/flow_presenter_test.rb Outdated Show resolved Hide resolved
We can't simply unpublish the old start page as this would remove the
entire flow as well - something we don't want to do. As a mitigation,
the old start page will now redirect to the new flow until the
migration is complete.

The old flow landing page has had the name matched with the new landing
page to ensure consistency.

This must be stripped out ASAP when migration is complete as highest
priority.
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6754 April 17, 2024 11:03 Inactive
@Tetrino Tetrino removed the DO NOT MERGE Needs further approval before release label Apr 17, 2024
@Tetrino Tetrino merged commit 8558b65 into main Apr 17, 2024
16 checks passed
@Tetrino Tetrino deleted the redirect-married-abroad branch April 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants