Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor check uk visa #6558

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactor check uk visa #6558

wants to merge 8 commits into from

Commits on Sep 19, 2023

  1. rename uk visa flow calculations and extract complex conditions

    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b23e394 View commit details
    Browse the repository at this point in the history

  2. simplify check uk visa travel to cta logic

    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8d94300 View commit details
    Browse the repository at this point in the history

  3. simplify check uk visa passing uk border logic

    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    466b29c View commit details
    Browse the repository at this point in the history

  4. refactor and extract methods for check uk visa length of stay logic

    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e93e5e8 View commit details
    Browse the repository at this point in the history

  5. move check uk visa work and study flow into private

    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    307e0e4 View commit details
    Browse the repository at this point in the history

  6. remove simple tests that are only checking single value equality

    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    dd50e6c View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. move check uk visa methods from flow to calculator 

    - also removing some unused methods
    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    2a73cae View commit details
    Browse the repository at this point in the history

  2. convert check-uk-visa study and work flow blocks to lambdas 

    - working around the edges of ruby method structures
    @FelixMarcusMillne
    FelixMarcusMillne committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f872b08 View commit details
    Browse the repository at this point in the history