Skip to content

Commit

Permalink
fix failing tests and linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
cynthia-anya committed Mar 27, 2024
1 parent 77cb531 commit 889c1f1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

##If you want to convert a civil partnership into a marriage

<% if calculator.passport_country_in_non_visa_national_list? || calculator.passport_country_in_eea? %>
<% if calculator.passport_country_in_non_visa_national_list? || calculator.passport_country_in_eea? %>
<%= render partial: "electronic_travel_authorisation_advice" %>
<% end %>
Expand Down
5 changes: 1 addition & 4 deletions test/flows/check_uk_visa_flow_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class CheckUkVisaFlowTest < ActiveSupport::TestCase
@b1_b2_country = "syria"
@youth_mobility_scheme_country = "canada"

@eta_text = "If you're travelling to the UK after September 2024"
@eta_text = "If youre travelling to the UK after September 2024"

# stub only the countries used in this test for less of a performance impact
stub_worldwide_api_has_locations(["china",
Expand Down Expand Up @@ -605,14 +605,12 @@ class CheckUkVisaFlowTest < ActiveSupport::TestCase
should "render specific guidance to British nationals overseas" do
add_responses what_passport_do_you_have?: "british-national-overseas"
assert_rendered_outcome text: "you can apply for a British National Overseas (BNO) visa."
assert_no_rendered_outcome text: "electronic travel authorisation (ETA)"
assert_rendered_outcome text: "You will not need a visa but"
end

should "render different guidance to non-British nationals overseas" do
add_responses what_passport_do_you_have?: @eea_country
assert_rendered_outcome text: "you must apply for a family visa"
assert_no_rendered_outcome text: "electronic travel authorisation (ETA)"
assert_rendered_outcome text: "You will not need a visa but"
end

Expand Down Expand Up @@ -957,7 +955,6 @@ class CheckUkVisaFlowTest < ActiveSupport::TestCase
add_responses what_passport_do_you_have?: @eea_country
assert_rendered_outcome text: @eta_text
end

end

context "outcome: outcome_work_n" do
Expand Down

0 comments on commit 889c1f1

Please sign in to comment.