New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightly clean up Sentry event logging. #385

Draft

sengi wants to merge 1 commit into main from sengi/sentry-cleanup

Contributor

sengi commented Aug 20, 2023

We're still quite some way from using the Sentry API as intended, but this at least makes our usage a bit less weird/buggy and more readable.

Send events to Sentry asynchronously, instead of blocking.
Allow up to 2 s to finish sending events to Sentry on exit.
Manage the lifecycle of the sentry.Client, Hub and Scope objects the way we're supposed to, rather than reinitialising Sentry every time we send an event.
Remove the unexported methods on our (still somewhat sketchy) ReportableError type; these weren't helping readability.

Relevant docs:

sengi force-pushed the sengi/sentry-cleanup branch from 88429f1 to 2d2f8c6 Compare

August 20, 2023 15:59

Base automatically changed from sengi/testability to main

August 21, 2023 10:51


          Lightly clean up Sentry event logging.

b191bc1

We're still quite some way from using the Sentry API as intended, but
this at least makes our usage a bit less weird/buggy and more readable.

- Send events to Sentry asynchronously, instead of blocking.
- Allow up to 2 s to finish sending events to Sentry on exit.
- Manage the lifecycle of the sentry.Client, Hub and Scope objects the
  way we're supposed to, rather than reinitialising Sentry every time we
  send an event.
- Remove the unexported methods on our (still somewhat sketchy)
  ReportableError type; these weren't helping readability.

Relevant docs:

- https://docs.sentry.io/platforms/go/usage/
- https://docs.sentry.io/platforms/go/enriching-events/scopes/
- https://docs.sentry.io/platforms/go/concurrency/
- https://docs.sentry.io/platforms/go/panics/
- https://docs.sentry.io/platforms/go/guides/http/
- https://github.com/getsentry/sentry-go/blob/master/_examples/http/main.go

sengi force-pushed the sengi/sentry-cleanup branch from 2d2f8c6 to b191bc1 Compare

August 21, 2023 19:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment