Stop logging varnish_id. #367
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sengi
force-pushed
the
sengi/rm-varnish-cruft
branch
from
847a815
to
14241ba
Compare
sengi
force-pushed
the
sengi/rm-varnish-cruft
branch
2 times, most recently
from
9fdd099
to
5bcc17f
Compare
This field appears to have been added speculatively, way back in pre-Fastly days when there was only our own Varnish in front of Router. I couldn't find any evidence of us ever having used this field, plus it gives incorrect results behind Fastly since it assumes there's at most one X-Varnish header on the request, whereas there are always [at least two] because of [the way Fastly works]. [at least two]: https://developer.fastly.com/reference/http/http-headers/X-Varnish/ [the way Fastly works]: https://developer.fastly.com/learning/vcl/using/#the-vcl-request-lifecycle
sengi
force-pushed
the
sengi/rm-varnish-cruft
branch
from
5bcc17f
to
3f8f7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't find any evidence of this ever having been used, and it gives incorrect results because it throws away all but one of the X-Varnish headers. Any request that's reached Router would have at least two of them.
It probably made sense back when we ran our own Varnish and before we had Fastly, when these IDs would have corresponded to request log lines in Varnish.