PP-9685 Dont process events for disabled webhook #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfount
force-pushed
the
PP-9685-dont-process-events-for-disabled-webhook
branch
3 times, most recently
from
d57e0d7
to
10dca52
Compare
When a webhook has status `DISABLED` do not include it in the valid webhook subscriptions. Add additional coverage to assert a webhook can be moved into this state by consumers.
sfount
force-pushed
the
PP-9685-dont-process-events-for-disabled-webhook
branch
from
10dca52
to
12cc786
Compare
|
@sfount can you remember if this was done elsewhere or not? Can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #380
When a webhook has status
DISABLEDdo not include it in the validwebhook subscriptions.
Add additional coverage to assert a webhook can be moved into this
state by consumers.