PP-12107: Fix failing test #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouldReturnInformationFromBuiltInDefaultBinRangeFiles was failing because in a build on the CI pipeline, real CSVs from Worldpay are copied to the src/main/resources/data-sources folder. Thus the card number 1234567890000000 will fail to be found. To get around this, use a well known test card number 4000056655665556 that is also publicly available in https://docs.stripe.com/testing?locale=en-GB and in the CSV from Worldpay. This commit also removes "-DskipTests" from the ARM Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldReturnInformationFromBuiltInDefaultBinRangeFiles was failing because in a build on the CI pipeline, real CSVs from Worldpay are copied to the src/main/resources/data-sources folder. Thus the card number 1234567890000000 will fail to be found. To get around this, use a well known test card number 4000056655665556 that is also publicly available in https://docs.stripe.com/testing?locale=en-GB and in the CSV from Worldpay.
This commit also removes "-DskipTests" from the ARM Dockerfile.