-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GOV.UK mobile section #4640
Conversation
405f3b3
to
9165fe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a technical standpoint so approving + nice work on pulling in the mobile repos 🪄. Left some content suggestions but feel free to a) get a content review and b) ignore if you don't agree.
@@ -0,0 +1,15 @@ | |||
<% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
9165fe3
to
1b85cb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving the comments - LGTM!
1b85cb1
to
345d8d5
Compare
This change adds a new section for the GOV.UK mobile app documentation.
We do not introduce too much by way of document structure at this point, preferring to leave those decisions for later. However, as the app itself is mobile native - i.e. is built in iOS and Android - it does naturally suggest a broad set of initial sections:
GitHub repository links have been added for iOS and Android.
A Notification banner has also been added to the
/mobile
page indicating that the mobile app (and therefore the documentation) is a work in progress.Jira GOVAPP-453