Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GOV.UK mobile section #4640

Merged
merged 4 commits into from
May 16, 2024
Merged

Add GOV.UK mobile section #4640

merged 4 commits into from
May 16, 2024

Conversation

gclssvglx
Copy link
Contributor

@gclssvglx gclssvglx commented May 9, 2024

This change adds a new section for the GOV.UK mobile app documentation.

We do not introduce too much by way of document structure at this point, preferring to leave those decisions for later. However, as the app itself is mobile native - i.e. is built in iOS and Android - it does naturally suggest a broad set of initial sections:

  • iOS - for iOS specific documentation
  • Android - for Android specific documentation
  • General - for documentation that is either the same for both iOS and Android, or documents that describe more general and architectural elements of the system and its development.

GitHub repository links have been added for iOS and Android.

A Notification banner has also been added to the /mobile page indicating that the mobile app (and therefore the documentation) is a work in progress.

Screenshots
Screenshot 2024-05-10 at 15 42 48
Screenshot 2024-05-10 at 15 42 23
Screenshot 2024-05-10 at 15 43 25
Screenshot 2024-05-10 at 15 43 07

Jira GOVAPP-453

@gclssvglx gclssvglx requested a review from 1pretz1 May 9, 2024 08:28
@gclssvglx gclssvglx changed the title Add GOV.UK mobile section DO NOT MERGE: Add GOV.UK mobile section May 9, 2024
@gclssvglx gclssvglx marked this pull request as draft May 9, 2024 09:18
@gclssvglx gclssvglx force-pushed the add-mobile-app-docs branch 2 times, most recently from 405f3b3 to 9165fe3 Compare May 10, 2024 14:38
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a technical standpoint so approving + nice work on pulling in the mobile repos 🪄. Left some content suggestions but feel free to a) get a content review and b) ignore if you don't agree.

source/mobile/index.html.md Outdated Show resolved Hide resolved
source/mobile/index.html.md Outdated Show resolved Hide resolved
source/mobile/index.html.md Outdated Show resolved Hide resolved
@@ -0,0 +1,15 @@
<%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the comments - LGTM!

@gclssvglx gclssvglx changed the title DO NOT MERGE: Add GOV.UK mobile section Add GOV.UK mobile section May 16, 2024
@gclssvglx gclssvglx marked this pull request as ready for review May 16, 2024 12:38
@gclssvglx gclssvglx merged commit 08e084c into main May 16, 2024
9 checks passed
@gclssvglx gclssvglx deleted the add-mobile-app-docs branch May 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants