Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend performance #899

Merged
merged 5 commits into from
May 16, 2024
Merged

Update frontend performance #899

merged 5 commits into from
May 16, 2024

Conversation

DavidBiddle
Copy link
Contributor

@DavidBiddle DavidBiddle commented May 9, 2024

Makes some updates to the FE performance page, as suggested by the frontend community. Main changes:

  • Some updates to style and wording on existing recommendations in the table
  • Removal of a couple of suggestions we don't think are relevant any more
  • Addition of new sections on HTTP2+ and code splitting

Makes some minor style and wording changes to the content in response to
comments during a review at the frontend community meeting.
Adds a section on code splitting to provide a bit more nuance to the
'minimise HTTP requests' guideline.
Adds a recommendation to enable HTTP/2 or HTTP/3, since this is now well
supported.
@DavidBiddle DavidBiddle marked this pull request as ready for review May 10, 2024 08:19
tombye
tombye previously approved these changes May 10, 2024
Copy link
Contributor

@tombye tombye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment but it seems like it also could just be my opinion so approving as everything else makes total sense and looks good to go 👍🏻

Thanks for doing the hard work of meeting and coming up with changes!

source/standards/optimise-frontend-perf.html.md.erb Outdated Show resolved Hide resolved
Clarifies the wording on this item to make it clearer that we're talking about minimising the number of requests, to avoid round trips to the server.
@DavidBiddle
Copy link
Contributor Author

Sorry @tombye, looks like your review got dismissed when I updated the bit about server round-trips - would you mind re-reviewing if you've got time?

Copy link
Contributor

@tombye tombye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks again for doing the work 👍🏻

@DavidBiddle DavidBiddle merged commit 9b165de into main May 16, 2024
1 check passed
@DavidBiddle DavidBiddle deleted the update-frontend-performance branch May 16, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants