Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission statement clarification, standards refs #895

Merged
merged 4 commits into from
May 29, 2024

Conversation

galund
Copy link
Contributor

@galund galund commented May 3, 2024

Update mission statement and clarify applicability outside GDS.

Also update some references to standards, policies and guidance.

Plus fix the Dockerfile cos there's always some yak shaving to be done.

@louzoid-gds
Copy link
Contributor

louzoid-gds commented May 14, 2024

Looking good. Makes sense to also update the site banner (layouts/custom.erb) with this batch of changes. Ok to include?

@galund
Copy link
Contributor Author

galund commented May 14, 2024

Looking good. Makes sense to also update the site banner (layouts/custom.erb) with this batch of changes. Ok to include?

Yes, I'm confused why the index page has its own layout. I'll try de-duplicating...

- all the custom layout does is add a note about applicability, which we want on this page too
@galund
Copy link
Contributor Author

galund commented May 14, 2024

Have de-duplicated, I can't see anything too obvious breaking from changing the layout of the index page, but someone should probably double check for me :)

@galund galund marked this pull request as ready for review May 14, 2024 15:36
@louzoid-gds
Copy link
Contributor

louzoid-gds commented May 15, 2024

Yes, I'm confused why the index page has its own layout. I'll try de-duplicating...

Quick blame defines me as the culprit but I couldn't tell you why :)
All looking good imo. I've pinged a security colleague for a thumbs up on the other content amends

Copy link
Contributor

@Jonathan-Scott14 Jonathan-Scott14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@louzoid-gds louzoid-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galund galund merged commit 3a42235 into main May 29, 2024
1 check passed
@galund galund deleted the intro-more-standards-security branch May 29, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants