Improve the spacing and alignment of search filters on mobile #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All 16px sizes increased to 19px in line with forthcoming DS changes * Extra top padding for first filter item, previously too short * Expander icons adjusted for better vertical alignment with text * Consistent spacing around second bold results text * Facets form now accounts for 2px shadow on the button
matthillco
added
dependencies
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improve the spacing and alignment of elements within the search filters component in the mobile view.
Trello card
Why
This component is a bit messy with several elements not lining up and the submit button falls outside the container. With the forthcoming changes to the font sizes, the spacing looks even worse and must be fixed. The improvements will help make this more visually consistent.
How
BEFORE / AFTER
Follow these steps if you are doing a Rails upgrade.