Mitchish kempner #352
Open
Mitchish kempner #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2023 19:45
dirkgr
requested changes
Nov 1, 2023
configs/mitchish7.yaml
Outdated
| load_path: null | ||
|
|
||
| max_duration: 423855 # 2T tokens | ||
| global_train_batch_size: 1536 |
There was a problem hiding this comment.
This is putting only 3M tokens into one batch.
configs/mitchish7.yaml
Outdated
|
|
||
| activation_checkpointing: by_layer | ||
|
|
||
| compile: null |
There was a problem hiding this comment.
Mitchish has a different config here.
compile:
fullgraph: false
| precision: amp_bf16 | ||
|
|
||
| max_grad_norm: 1.0 | ||
|
|
There was a problem hiding this comment.
We should explicitly set max_grad_norm_ratio as well, just in case.
scripts/kempner/mitchish.sh
Outdated
| --run_name=kempner_mitchish7_${SLURM_JOB_ID} \ | ||
| --save_folder=/n/holyscratch01/kempner_lab/Lab/checkpoints/${SLURM_JOB_ID}/ \ | ||
| --data.num_workers=4 \ | ||
| --device_train_microbatch_size=6 \ |
There was a problem hiding this comment.
This works when the global batch size is divisible by 6, but it should not be. The fact that it is is a bug.
scripts/kempner/mitchish.sh
Outdated
| --distribution=block:block \ | ||
| --kill-on-bad-exit \ | ||
| scripts/run_with_environment.sh \ | ||
| $HOME/miniconda3/envs/LLM/bin/python -u scripts/train.py configs/llama7.yaml \ |
There was a problem hiding this comment.
This is referring to the wrong config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.