New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add triton implementation of layer norm #260
Draft
epwalsh
wants to merge
34
commits into
main
Choose a base branch
from
petew/triton
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
changed the title
Add some experimental triton components
Add triton implementation of layer norm
Sep 20, 2023
epwalsh
added
the
status/blocked
Progress can't be made because we're waiting on something outside of our control
label
Sep 26, 2023
I'm marking this blocked until we figure out what's wrong with triton on LUMI. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/blocked
Progress can't be made because we're waiting on something outside of our control
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #258.
Adds a triton implementation of layer norm. At the moment this builds on #274, so either one can be merged.
I've included a benchmark that you can run with:
I've also added a script for building wheels from AMD's fork of triton. As far as I know the script can be ran on any Linux machine (such as a Beaker interactive session on cirrascale):
This will build and upload the wheel to
s3://ai2-llm/wheels/
. I've already built one and tested it on LUMI.You can run the tests on LUMI like this:
At the moment the low-precision tests are failing, but at least the fp32 ones pass. I've opened an issue here with a minimal example: ROCm/triton#323