WIP: basic marimekko #1011
Draft
WIP: basic marimekko #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianmroz-allegro
force-pushed
the
marimekko
branch
from
97d77cd
to
35593e4
Compare
… here or maybe change size in e2e test
|
⏱️ Lighthouse report |
size-limit report 📦
|
|
✅ Deployed successfully to: https://turnilo-marimekko-gmbbyye42a-ew.a.run.app |
|
⏱️ Lighthouse report |
|
✅ Deployed successfully to: https://turnilo-marimekko-gmbbyye42a-ew.a.run.app |
| @@ -37,9 +37,9 @@ export function omitFalsyValues<T>(obj: T): Partial<T> { | |||
|
|
|||
| type Key = string; | |||
|
|
|||
| export function mapValues<K extends Key, S, T>(obj: Record<K, S>, fn: Unary<S, T>): Record<K, T> { | |||
| export function mapValues<K extends Key, S, T>(obj: Record<K, S>, fn: Binary<S, K, T>): Record<K, T> { | |||
There was a problem hiding this comment.
Add unit test for added keys parameter
| @@ -24,7 +24,7 @@ import { LinearScale } from "../../../utils/linear-scale/linear-scale"; | |||
| const MARGIN = 40; | |||
| const X_AXIS_HEIGHT = 50; | |||
| const Y_AXIS_WIDTH = 50; | |||
| const BREAKPOINT_SMALL = 768; | |||
| const BREAKPOINT_SMALL = 748; | |||
There was a problem hiding this comment.
Do we change it here? Or adjust e2e test for Large Screen?
| @@ -509,7 +509,8 @@ export class CubeView extends React.Component<CubeViewProps, CubeViewState> { | |||
| return menuStage.within({ | |||
| left, | |||
| right, | |||
| top: CONTROL_PANEL_HEIGHT | |||
| top: CONTROL_PANEL_HEIGHT, | |||
| bottom: 20 // TODO: from .cube-view .center-panel margins | |||
There was a problem hiding this comment.
Ugh, somehow we should resolve this. Right now visualisations have bigger stage than is available.
| @@ -0,0 +1,209 @@ | |||
| /* | |||
There was a problem hiding this comment.
This file is as WIP as it gets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.