support huge amount of datacubes #1004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution, we'll review the changes. Due to a Christmas break you could expect the review in the beginning of the new year. |
shacharHagu
reviewed
Dec 26, 2022
shacharHagu
reviewed
Dec 26, 2022
…usters and adding pagination to the `/sources/dataCubes`
bikov
force-pushed
the
support-large-ammount-of-datasources
branch
from
13a888a
to
4a0ade5
Compare
src/client/utils/ajax/ajax.ts
Outdated
| let dataCubesResult: SerializedDataCube[] = []; | ||
| let isDone = false; | ||
| let batch = 0; | ||
| while (!isDone) { |
There was a problem hiding this comment.
I'm wondering if we could extract this to async iterator and with for await ... of. That's very loose idea though!
…usters and adding pagination to the `/sources/dataCubes` - CR fixes
|
@adrianmroz-allegro Thank you for the review - I've fixed the comments |
|
@bikov oh, that's unfortunate :) We were discussing your PR on one of our meetings and I'm finishing my implementation of this feature. If that's ok with you I'd like to push my solution and get review from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a large number of datasources in our use - and when trying to use Turnilo we are getting
{"error": "Can't fetch settings", "message": "Invalid string length"}when querying/sourcesThis should help us to support our use case with a large number of datacubes by splitting datacubes API from clusters API and adding pagination to the
/sources/dataCubes