Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed previousVersion for tagged commits #413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed previousVersion for tagged commits #413

wants to merge 1 commit into from

Conversation

EisenRatte
Copy link

Hi
this should fix #395

@EisenRatte EisenRatte mentioned this pull request Jul 29, 2021
Open
@bgalek
Copy link
Collaborator

bgalek commented Jul 29, 2021

hi @EisenRatte! Your PR LGTM!
@mockitoguy are you happy with this change regarding #395? :)

@bgalek
Copy link
Collaborator

bgalek commented Jul 29, 2021

yet, some tests broke @EisenRatte check them out ;)

@EisenRatte
Copy link
Author

yet, some tests broke @EisenRatte check them out ;)

I forgot about the usecase of having multiple version tags on the latest commit.
I'm worried because the behaviour of previousVersion for that usecase is not defnied in the documentation and that my PR will change too much.
I can't make that decision for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgalek bgalek bgalek approved these changes

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Previous version is the same as current version when building tags
2 participants
@EisenRatte @bgalek