Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added regex to filter out tags which overlap in repo #242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Darkest
Copy link

@Darkest Darkest commented Jun 11, 2018

This pull request fixes the following restriction: tag prefixes for each module do not overlap, i.e. !tagA.startsWith(tagB) for each permutation of all tag prefixes

Now tags are filtered by stronger regex, filtering out all tags that do not match the pattern -

@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.325% when pulling 517dc1d on Darkest:master into 5c461cf on allegro:master.

@adamdubiel
Copy link
Member

This looks really nice, but i'm worried about one thing: user can override tag serialization (using scmVersion.tag.serialize property) and chosen tag serialization might not match stronger regexp.. i'm not yet sure if this is a blocker, but to be on a safe side you might add a config flag to turn "strong regexp" on/off. It could be on by default in 1.10.0 . What do you think?

@Darkest
Copy link
Author

Darkest commented Jun 17, 2018

I got your idea. Will look into it as i have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants