Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip input frame instead of preview image #333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JohanAR
Copy link
Collaborator

@JohanAR JohanAR commented Dec 28, 2020

Flip the source stream instead of just the preview window.

The difference (for the user) is that the old behaviour would appear to flip both the input and the avatar, while now the avatar stays in the same orientation. This change can make it easier to get a comfortable alignment with the avatar if one has the webcam slightly off to the side

@alievk
Copy link
Owner

alievk commented Dec 29, 2020

Actually I never used the T key feature, this was merged from a fork in the early days. I tested your modification and, honestly. I didn't get the point. This is only because I don't use this option and it's hard to me to judge.

@JohanAR
Copy link
Collaborator Author

JohanAR commented Dec 29, 2020

I have my webcam slightly under my left monitor, so it will either see me straight ahead or from the left side (when I'm looking at my right monitor). Now if I have an avatar where the subject is looking right it will be quite awkward for me to match it. I have to look to the left side of my left monitor during calibration, which is doable, but whenever I turn to look at my right monitor my pose is too far from the calibration and gives really bad results.

If I can flip the input video I can match a right-facing avatar by looking at my right monitor (because it's now mirrored) which is much easier.

@alievk
Copy link
Owner

alievk commented Jan 8, 2021

Hey @JohanAR, what's your email? I would like to talk to you.

@JohanAR
Copy link
Collaborator Author

JohanAR commented Jan 8, 2021

Hmm, I would've expected github to have private messages, but it seems like it doesn't.. Anyhow, my mail is [redacted] ,but I also have Discord, IRC and Hangouts in case you want a faster conversation

@ochen1
Copy link

ochen1 commented Jan 10, 2021

@JohanAR You do know that, although GitHub does not feature private DMs, it logs issue comment edits, right? So therefore [redact]ing emails have no real purpose? 😅

@JohanAR
Copy link
Collaborator Author

JohanAR commented Jan 10, 2021

I did not know that :D Just thought I'd reduce the risk of spam bots scraping up my email, but it's not super secret or anything

@Collinsmk123

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants