bugfix: http2 directive should not work on h2c #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http2 directive works on HTTP2 over TLS not on HTTP2 cleartext. For HTTP2 cleartext, the default server still controls using http2 or not. the "http2 off;" line in other servers is not going to work as expected. So, we should just make http2 directive only affects HTTP2 over TLS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http2 directive works on HTTP2 over TLS not on HTTP2 cleartext.
For HTTP2 cleartext, the default server still controls using http2
or not. the "http2 off;" line in other servers is not going to work
as expected.
So, we should just make http2 directive only affects HTTP2 over TLS.