Dangling pointer bugfix for upstream check module while update the upstream via dyups #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `ngx_http_dyups_module` and `ngx_http_upstream_check_module` are used together. Because dyups has its own srv_conf and it will be freed when the upstream is deleted, but upstream check timer will still be exists and access its srv conf via peer->conf. To avoid dangling pointer access, we should delete the dynamic peer while its upstream is deleting.
|
I have found a commit of yzprofile/nginx_upstream_check_module@2eb4451 use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dangling pointer access, while
ngx_http_dyups_moduleandngx_http_upstream_check_moduleare used together.Because
dyupshas its ownsrv_confand it will be freed when the upstream is deleted,but upstream check timer will still be exists and access its srv conf via
peer->conf.To avoid dangling pointer access, we should delete the dynamic peer while its upstream is deleting.