Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable linters checks #131

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Xunzhuo
Copy link
Collaborator

@Xunzhuo Xunzhuo commented Jan 18, 2023

Signed-off-by: bitliu bitliu@tencent.com

Ⅰ. Describe what this PR did

feat: enable linters checks

Signed-off-by: bitliu <bitliu@tencent.com>
@codecov-commenter
Copy link

Codecov Report

Merging #131 (ff4a06d) into main (b410fc9) will increase coverage by 0.44%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   25.88%   26.32%   +0.44%     
==========================================
  Files          26       26              
  Lines        4524     4524              
==========================================
+ Hits         1171     1191      +20     
+ Misses       3277     3257      -20     
  Partials       76       76              
Impacted Files Coverage Δ
pkg/bootstrap/server.go 62.97% <0.00%> (+7.63%) ⬆️

@Xunzhuo
Copy link
Collaborator Author

Xunzhuo commented Jan 18, 2023

I did not enable linter yet, because there are many lint errors need to be resolved. Try make lint to see them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants