Add plugin real-ip #115
Draft
Add plugin real-ip #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strangevy
requested review from
johnlanni,
SpecialYang,
Lynskylate,
gengleilei and
NameHaibinZhang
as code owners
|
|
spacewander
reviewed
Dec 31, 2022
johnlanni
requested changes
Jan 4, 2023
dspo
reviewed
Jan 5, 2023
Strangevy
force-pushed
the
wasm-plugin-real-ip
branch
from
c3e2489
to
297ce43
Compare
johnlanni
reviewed
Feb 3, 2023
| host = realIp | ||
| } | ||
|
|
||
| err = proxywasm.SetProperty([]string{"remote", "address"}, []byte(host)) |
There was a problem hiding this comment.
This feature is still waiting to be implemented, this PR is temporarily hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Add a wasm plugin that the functional equivalent of nginx real_ip module
Ⅱ. Does this pull request fix one issue?
fixes #92
Ⅲ. Why don't you add test cases (unit test/integration test)?
No unit tests yet
Ⅳ. Describe how to verify it
The real IP can be obtained by configuring related attributes according to the README.md
Ⅴ. Special notes for reviews
Check README.md