Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to load node embeddings into memory with FP16 format #77

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Elnifio
Copy link

@Elnifio Elnifio commented Aug 18, 2023

This PR gives a new command-line argument --use_fp16 that, when added, allows the user to load node embeddings into memory with FP16 format. With this argument, the memory-mapped node features will be loaded into memory from disk with FP16 format. This allows users to run the training code on large dataset (IGBH-Large & IGBH-Full, for instance, or IGBH-Medium, which requires >128GB memory) on devices with smaller memory size.

From our current running result, we see that the accuracy is the same when training with FP16 vs. FP32. This is verified on IGBH-Small, IGBH-Medium, and IGBH-Large.

We need to note that with this argument, we load all node features into the memory by default, regardless of whether --in_memory is true.

Additionally, this PR also fixes the type of command-line argument --learning_rate, so that we can actually control the learning rate from bash script, instead of modifying the actual .py file.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


yunzhoul seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@LiSu LiSu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants