Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element): wrong RadioGroup optionType value #4083

Open
wants to merge 1 commit into
base: formily_next
Choose a base branch
from

Conversation

imshenshen
Copy link

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

对于 RadioGroupPropsoptionType 属性值 ,组件文档、代码中都使用了 default ,但是 type RadioGroupProps 没有正确的标识 optionType

@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (4dc50bc) to head (98d5649).
Report is 2 commits behind head on formily_next.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #4083   +/-   ##
=============================================
  Coverage         99.55%   99.55%           
=============================================
  Files               152      152           
  Lines              6726     6726           
  Branches           1823     1823           
=============================================
  Hits               6696     6696           
  Misses               30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imshenshen
Copy link
Author

@janryWang 有人review么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants