Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: baseReaction 初始化执行两次的问题 #4080

Open
wants to merge 1 commit into
base: formily_next
Choose a base branch
from

Conversation

unclechong
Copy link

patchSchemaCompile 收集了 field.initialized
field在初始化结束后会标记 field.initialized = true
所以 base reacttion 全部都会执行两次

修复:field.initialized 丢在 untracked 中,不在进行收集

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

patchSchemaCompile 收集了 field.initialized
field在初始化结束后会标记  field.initialized = true
所以 base reacttion 全部都会执行两次

修复:field.initialized 丢在 untracked 中,不在进行收集
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@unclechong unclechong changed the title 修复 baseReadtion 初始化执行两次的问题 修复 baseReaction 初始化执行两次的问题 Jan 24, 2024
@unclechong unclechong changed the title 修复 baseReaction 初始化执行两次的问题 fix: baseReaction 初始化执行两次的问题 Jan 24, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fa68e6) 99.55% compared to head (dc2cfa0) 99.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #4080   +/-   ##
=============================================
  Coverage         99.55%   99.55%           
=============================================
  Files               152      152           
  Lines              6720     6721    +1     
  Branches           1822     1822           
=============================================
+ Hits               6690     6691    +1     
  Misses               30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants