Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

代码精简 #5886

Merged
merged 1 commit into from
May 9, 2024
Merged

代码精简 #5886

merged 1 commit into from
May 9, 2024

Conversation

mek1986
Copy link
Contributor

@mek1986 mek1986 commented May 5, 2024

  1. 代码逻辑简化
  2. .无用代码消除
  • 合并了merge记录,重新提交

@lizongbo
Copy link
Collaborator

lizongbo commented May 5, 2024

再核实一下你改动的原因,如果仅仅是简化待而引入风险,宁可不改。

@mek1986
Copy link
Contributor Author

mek1986 commented May 5, 2024

再核实一下你改动的原因,如果仅仅是简化待而引入风险,宁可不改。
这里有修复空指针:当holder==null,holder.getConnectionId()会导致运行异常
LOG.error("{conn-" + (holder != null ? holder.getConnectionId() : "null") + "} discard", error);

@lizongbo
Copy link
Collaborator

lizongbo commented May 6, 2024

再核实一下你改动的原因,如果仅仅是简化待而引入风险,宁可不改。
这里有修复空指针:当holder==null,holder.getConnectionId()会导致运行异常
LOG.error("{conn-" + (holder != null ? holder.getConnectionId() : "null") + "} discard", error);

discard不是必然为true的。为什么要去掉?

@mek1986
Copy link
Contributor Author

mek1986 commented May 8, 2024

再核实一下你改动的原因,如果仅仅是简化待而引入风险,宁可不改。
这里有修复空指针:当holder==null,holder.getConnectionId()会导致运行异常
LOG.error("{conn-" + (holder != null ? holder.getConnectionId() : "null") + "} discard", error);

discard不是必然为true的。为什么要去掉?
说明

@lizongbo lizongbo merged commit e08e92e into alibaba:master May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants