Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unary operator for identifier #5862

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix unary operator for identifier #5862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1438c57
Fix unary operator for identifier
ZhengguanLi Apr 22, 2024
e458578
Fix unit test
ZhengguanLi Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/com/alibaba/druid/sql/dialect/oracle/parser/OracleExprParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,12 @@ public SQLExpr primary() {
sqlExpr = new OracleBinaryDoubleExpr(Double.parseDouble(lexer.numberString()) * -1);
lexer.nextToken();
break;
case IDENTIFIER:
sqlExpr = primary();
sqlExpr = new SQLUnaryExpr(SQLUnaryOperator.Negative, sqlExpr);
break;
case VARIANT:
case QUES:
case IDENTIFIER:
case LITERAL_ALIAS:
sqlExpr = expr();
sqlExpr = new SQLUnaryExpr(SQLUnaryOperator.Negative, sqlExpr);
Expand Down
17 changes: 17 additions & 0 deletions ...test/java/com/alibaba/druid/bvt/sql/oracle/select/OracleSelectTest83_number_negative.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,21 @@ public void test_0() throws Exception {
// Assert.assertTrue(visitor.containsColumn("sup_task", "orgid"));
//
}

public void test_1() throws Exception {
String sql = "SELECT * FROM employees WHERE -salary < 0 ORDER BY employee_id";

OracleStatementParser parser = new OracleStatementParser(sql);
List<SQLStatement> statementList = parser.parseStatementList();
SQLStatement statement = statementList.get(0);
print(statementList);

Assert.assertEquals(1, statementList.size());

OracleSchemaStatVisitor visitor = new OracleSchemaStatVisitor();
statement.accept(visitor);

Assert.assertEquals(1, visitor.getTables().size());
Assert.assertEquals(3, visitor.getColumns().size());
}
}