Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect MERGE statement update/insert clause visit order #5836

Conversation

ZhengguanLi
Copy link
Contributor

@ZhengguanLi ZhengguanLi commented Apr 10, 2024

使MERGE statement traverse的顺序跟本来的SQL也保持一致

@lizongbo
Copy link
Collaborator

补充一下单元测试用例代码吧

@ZhengguanLi
Copy link
Contributor Author

补充一下单元测试用例代码吧

不太需要添加单元测试好像 现在已有的 OracleMergeTest 和 OracleMerge10Test已经包含了MERGE statement两种不同的顺序组合,这里就是使traverse的顺序跟本来的SQL也保持一致, 因为我们依赖于这些顺序提取一些信息

@lizongbo lizongbo merged commit 34bd5f1 into alibaba:master Apr 11, 2024
5 checks passed
@ZhengguanLi ZhengguanLi deleted the pr/merge-statement-insert-update-visit-order branch April 11, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants