Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an inaccurate error message when parsing a log level from a string #3221

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SkipperQ
Copy link

@SkipperQ SkipperQ commented Sep 2, 2023

Describe what this PR does / why we need it

Fix a bug where an inaccurate error message is displayed when parsing a log level from a string due to the incorrect use of the logLevel variable instead of logLevelString in the error message.

Does this pull request fix one issue?

Fixes #3192

Describe how you did it

Replace logLevel with logLevelString.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2023

CLA assistant check
All committers have signed the CLA.

@SkipperQ
Copy link
Author

SkipperQ commented Sep 3, 2023

@sczyh30

Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp added the area/logging Issues or PRs related to logging of Sentinel label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to logging of Sentinel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] com.alibaba.csp.sentinel.log.LogBase#loadProperties() 日志输出bug
3 participants