openssl not use locking after 1.1.0 #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beef9999
force-pushed
the
beef9999/br-06
branch
from
acb422b
to
ca70993
Compare
beef9999
commented
Mar 31, 2024
| @@ -281,9 +281,9 @@ IFileSystem* new_httpfs_v2(bool default_https, uint64_t conn_timeout, | |||
| client, client_ownership); | |||
| } | |||
|
|
|||
| IFile* new_httpfile_v2(const char* url, HttpFs_v2* httpfs, uint64_t conn_timeout, | |||
| IFile* new_httpfile_v2(const char* url, IFileSystem* httpfs, uint64_t conn_timeout, | |||
There was a problem hiding this comment.
mismatch to header file, cause undefined symbols
lihuiba
reviewed
Apr 1, 2024
| @@ -139,7 +139,8 @@ class KernelSocketStream : public SocketStreamBase { | |||
| return (Object*) (uint64_t) fd; | |||
| } | |||
| int close() final { | |||
| get_vcpu()->master_event_engine->wait_for_fd(fd, 0, -1UL); | |||
| @@ -76,17 +76,21 @@ class GlobalSSLContext : public Singleton<GlobalSSLContext> { | |||
| OpenSSL_add_all_ciphers(); | |||
| OpenSSL_add_all_digests(); | |||
| OpenSSL_add_all_algorithms(); | |||
| #if OPENSSL_VERSION_NUMBER < 0x10100000L | |||
There was a problem hiding this comment.
Is there a function to obtain openssl version dynamically? If so, it's better to use if instead of #if.
There was a problem hiding this comment.
SSLeay_version(). But it will output string like OpenSSL 1.0.1a 15 Oct 2015, not handy to use.
There was a problem hiding this comment.
According to https://github.com/openssl/openssl/blob/OpenSSL_1_1_0-stable/crypto/cversion.c
we can use SSLeay() for versions before 1.1, and OpenSSL_version_num() for those after 1.1.
There was a problem hiding this comment.
We can probe for the above functions with dlopen(filename==NULL) and dlsymbol(), and decide which one to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going to backport to 0.7