Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): support a general Intersect implementation in GIE Runtime #3689

Merged
merged 22 commits into from May 14, 2024

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Apr 3, 2024

What do these changes do?

As titled.

This pr mainly includes:

  1. Refactor the convert logic of Intersect in GraphRelToProtoConverter in Compiler
  2. Refactor the parsing and processing logic of Intersect in assembly in Runtime
  3. Support a more general Intersect that can preserve the edges during intersection, in Runtime
  4. Add a micro benchmark framework, and testing for general_intersection v.s. optimized_intersection. The results shows that, on ldbc dataset (sf=1), to find matches for a triangle (a,b,c knows each other), general_intersection's time cost is about 1.7\times of optimized_intersection's, as the general_intersection further preserves all matched edges during the intersection computation.

Related issue number

Fixes #3685 #3745

@BingqingLyu BingqingLyu marked this pull request as draft April 3, 2024 09:33
@BingqingLyu BingqingLyu changed the title fix(interactive): refactor the converter and implementation of Intersect operator in GIE [WIP] fix(interactive): refactor the converter and implementation of Intersect operator in GIE Apr 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.17%. Comparing base (dbfc0e1) to head (a4edb34).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3689   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files         188      188           
  Lines       17264    17264           
=======================================
  Hits         4518     4518           
  Misses      12746    12746           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbfc0e1...a4edb34. Read the comment docs.

@BingqingLyu BingqingLyu changed the title [WIP] fix(interactive): refactor the converter and implementation of Intersect operator in GIE fix(interactive): refactor the converter and implementation of Intersect operator in GIE Apr 23, 2024
@BingqingLyu BingqingLyu marked this pull request as ready for review April 23, 2024 11:44
Committed-by: bingqing.lbq from Dev container
@BingqingLyu BingqingLyu changed the title fix(interactive): refactor the converter and implementation of Intersect operator in GIE fix(interactive): support a general Intersect implementation in GIE Runtime Apr 24, 2024
…intersect with optimized intersect

Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
Committed-by: bingqing.lbq from Dev container
@@ -0,0 +1,197 @@
#![feature(test)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright is missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Committed-by: bingqing.lbq from Dev container
@BingqingLyu BingqingLyu merged commit 348a2b7 into alibaba:main May 14, 2024
57 of 58 checks passed
@BingqingLyu BingqingLyu deleted the refactor_intersect branch May 14, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Intersect in GIE Physical Layer and Runtime
5 participants