Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(python): Decode the k8s node selector and convert it as a dict. #3477

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dashanji
Copy link
Collaborator

What do these changes do?

As titled.

During test, I find not all pods are scheduled to the same node.

NAME                                             READY   STATUS    RESTARTS   AGE     IP            NODE           NOMINATED NODE   READINESS GATES
coordinator-ozgjbb-6c57549cf7-hhwqt              1/1     Running   0          4m2s    10.244.1.85   kind-worker    <none>           <none>
gs-engine-ozgjbb-0                               3/3     Running   0          3m58s   10.244.1.86   kind-worker    <none>           <none>
gs-engine-ozgjbb-1                               3/3     Running   0          114s    10.244.1.87   kind-worker    <none>           <none>
gs-engine-ozgjbb-2                               3/3     Running   0          108s    10.244.1.88   kind-worker    <none>           <none>
gs-engine-ozgjbb-ozgjbb-vineyard-etcd-0          1/1     Running   0          3m58s   10.244.3.71   kind-worker2   <none>           <none>
gs-interactive-frontend-ozgjbb-8d996bc8b-ctn6x   1/1     Running   0          3m58s   10.244.3.72   kind-worker2   <none>           <none>

We should support to add the node selector to the frontend and vineyard etcd.

Related issue number

Fixes #3476

siyuan0322
siyuan0322 previously approved these changes Jan 30, 2024
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9228223) 48.81% compared to head (56249ce) 45.34%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3477      +/-   ##
==========================================
- Coverage   48.81%   45.34%   -3.47%     
==========================================
  Files         177      176       -1     
  Lines       16198    16171      -27     
==========================================
- Hits         7907     7333     -574     
- Misses       8291     8838     +547     
Files Coverage Δ
...n/graphscope/deploy/kubernetes/resource_builder.py 24.89% <0.00%> (-47.46%) ⬇️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9228223...56249ce. Read the comment docs.

@dashanji dashanji changed the title fix(python): Decode the k8s node selector and convert it as a dict. [WIP] fix(python): Decode the k8s node selector and convert it as a dict. Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] session config k8s_coordinator_pod_node_selector Not effective
3 participants