feat(interactive): Refactor and fix some bugs for AdminService
#3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
force-pushed
the
admin_service
branch
from
a5f011c
to
2ca785a
Compare
zhanglei1949
changed the title
AdminServiceAdminService
zhanglei1949
changed the title
AdminServiceAdminService
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3406 +/- ##
=======================================
Coverage 27.76% 27.76%
=======================================
Files 178 178
Lines 16245 16245
=======================================
Hits 4511 4511
Misses 11734 11734 Continue to review full report in Codecov by Sentry.
|
zhanglei1949
changed the title
AdminServiceAdminService
liulx20
previously approved these changes
Mar 5, 2024
lidongze0629
previously approved these changes
Mar 5, 2024
zhanglei1949
force-pushed
the
admin_service
branch
from
5a02274
to
d632f2a
Compare
author xiaolei.zl <xiaolei.zl@alibaba-inc.com> 1701935806 +0800 committer xiaolei.zl <xiaolei.zl@alibaba-inc.com> 1710748155 +0800 1. set default stored_procedures for graph schema. 2. use nlohmann-json to convert yaml to json fix some bug fix workflow file make loading_method enum ongoing: change http return code fix bug fix fix fix fix fix error fix fix make load graph sync support non-blocking dataloading fix bug and make job_id string fix start/end_time fix resource object lock_file and AtomicIntDecrementer fix adhoc fix rebase and refine minor fix refactor minor refine doc fix fix aocc warning can start compiler in interactive_server rename fix minor format minor fix fix fix fix
zhanglei1949
force-pushed
the
admin_service
branch
from
835d706
to
8fc19e1
Compare
|
This PR has been divided into several small, merged PRs into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we refactor some of the Interactive
AdminServiceand fix some bugs.bulk_loading_job_count_.AdminActorAPIs returnseastar::future<gs::Result<seastar::sstring>>, with a mapping betweengs::StatusCodeand http status code, we can remove a lot of dummy code handling exception/unexpected behaviors.Fix #3515