fix: putBucketLifecycle add ColdArchive and DeepColdArchive #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YunZZY
reviewed
Oct 16, 2023
| if (!['IA', 'Archive'].includes(rule.transition.storageClass)) | ||
| throw new Error('StorageClass must be IA or Archive'); | ||
| if (!['IA', 'Archive', 'ColdArchive', 'DeepColdArchive'].includes(rule.transition.storageClass)) | ||
| throw new Error('StorageClass must be IA、Archive、ColdArchive、DeepColdArchive'); |
There was a problem hiding this comment.
存储类型的检查提个方法出来，transition和noncurrentVersionTransition都要用；这个error message多了一个空格，而且存储类型间应该是或的关系，要用or
test/config.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| const { env } = process; | |||
|
|
|||
| const config = module.exports; | |||
| const USWEST = 'oss-us-west-1'; // ONCI=true Using the region of Silicon Valley in the United States would be faster | |||
| const USWEST = 'oss-ap-southeast-1'; // ONCI=true Faster using oss-ap-outsoutheast-1 | |||
There was a problem hiding this comment.
代码注释拼写错误，且和签名的变量命名不一致，有办法同时支持美西和新加坡吗
There was a problem hiding this comment.
没有必要同时支持 美西和新加坡吧，要加的话，改动有点大
There was a problem hiding this comment.
我理解只是在这里加一个新的配置，库增加一个变量，在UT里增加一个bucket就好吧，后面直接用就行
test/node/bucket.test.js
Outdated
| @@ -987,7 +1020,7 @@ describe('test/bucket.test.js', () => { | |||
| ]); | |||
| assert(false); | |||
| } catch (error) { | |||
| assert(error.message.includes('IA or Archive')); | |||
| assert(error.message.includes('IA、Archive')); | |||
There was a problem hiding this comment.
四种存储类型，这里就两个，而且是或的关系，上面的描述也要改吧
test/node/multiversion.test.js
Outdated
| const { rules } = await store.getBucketLifecycle(bucket); | ||
| const [ | ||
| { | ||
| noncurrentVersionTransition: { noncurrentDays, storageClass } | ||
| } | ||
| ] = rules; | ||
|
|
||
| assert(noncurrentDays === '10' && storageClass === 'IA'); |
YunZZY
reviewed
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.