Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data indexing API #1255

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: add data indexing API #1255

wants to merge 15 commits into from

Conversation

shungang
Copy link
Collaborator

No description provided.

@shungang shungang temporarily deployed to ali_oss_AK September 26, 2023 02:17 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK September 26, 2023 02:17 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK September 26, 2023 02:17 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK September 26, 2023 02:25 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK September 26, 2023 02:32 — with GitHub Actions Inactive
lib/common/bucket/dataIndex.ts Show resolved Hide resolved
MetaQuery: {
NextToken: queryParam.nextToken,
MaxResults: queryParam.maxResults,
Query: JSON.stringify(queryParam.query),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接转成JSON字符串了,里面的key不需要处理成大写吗

lib/common/bucket/dataIndex.ts Show resolved Hide resolved
@@ -2509,4 +2510,26 @@ describe('browser', () => {
}
});
});

// oss server 不支持跨域 大概要到9月30号才上生产支持 跨域,后端是:云仁
Copy link
Collaborator

@YunZZY YunZZY Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在应该可以了,这里的case加一下,要保证所有的参数都有设置一下,保证覆盖率

test/node/bucket.test.js Show resolved Hide resolved
it('doMetaQuery()', async () => {
try {
const queryParam = {
query: { operation: 'and', subQueries: [{ Field: 'Size', Value: '1048576', Operation: 'lt' }] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数设置全一些,都覆盖一下吧,参考一下文档示例

it('doMetaQuery() Aggregations', async () => {
try {
const queryParam = {
query: { operation: 'and', subQueries: [{ Field: 'Size', Value: '1048576', Operation: 'lt' }] },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参数设置全一些,subQueries类型这里对不上,改一下

@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:09 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:09 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:16 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:24 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:28 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:28 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:30 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 07:35 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 08:43 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 08:43 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 08:50 — with GitHub Actions Inactive
@shungang shungang temporarily deployed to ali_oss_AK October 17, 2023 08:57 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants